Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run config fails reproducible (locally + Cloud9) with default settings #592

Open
markusz opened this issue Oct 22, 2024 · 8 comments
Open

Comments

@markusz
Copy link

markusz commented Oct 22, 2024

Running npm run config fails reproducible when following the deploy instructions.

I get the following error:

Could not complete the operation.
Cannot set properties of undefined (setting 'default')

I verified npm run config failing in different environments and configurations

  • node v18 & v20
  • Cloud9 & locally
  • Default config values vs custom config

Steps to reproduce:

  1. Clone the repository and checkout main. This will point to v3.1.3 of the aws-genai-llm-chatbot
  2. Follow the instructions for Cloud9 / local deployment
  3. Use default values for all inputs

image

@markusz
Copy link
Author

markusz commented Oct 22, 2024

v4.0.14 works, but main still points to v3.1.3, so this likely affects everyone following the deploy instructions in the docs

@markusz
Copy link
Author

markusz commented Oct 22, 2024

Workaround

  • Download v4.0.14 or higher manually from here
  • Unzip
  • Continue with Step 2 of the deployment

@charles-marion
Copy link
Collaborator

Added a fix in #594

@markusz
Copy link
Author

markusz commented Oct 22, 2024

That was fast. Thanks!

@yoavchaws
Copy link

Well, when I run "npm run config" in Cloud9 in eu-central-1, selecting RAG with Knowledge base, it exits without asking me to save a config file and no config.json is created. Same with "npm run create". I suspect it is related to the change done to config.ts for this fix.
2024-10-24_09-41-02

@charles-marion
Copy link
Collaborator

@yoavchaws , I added a fix. Sorry about that.

@yoavchaws
Copy link

Thanks @charles-marion. The fix works fine. However, when I create a bedrock based RAG configuration, it does not ask me for the embedding model (embeddingModels[]) to use. As a result, the cdk bootstrap operation falls later with "no embedding model set".
A work around is to change one of the embeddingModels[].default to true.

@charles-marion
Copy link
Collaborator

Added a fix in the PR #598 .
Please use the work around listed above until merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants