-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map): add pointcloud divider and pointcloud merger #100
feat(map): add pointcloud divider and pointcloud merger #100
Conversation
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
… rearrange files Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
…ang format Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
@SakodaShintaro Thank you for reviewing the point cloud divider.
I found a problem with the code. The file you shared is a bit different from usual PCD files. Its header look like this
A typical PCD's header often looks like this
I don't know how your file was created but the order of point fields was changed, and there is some padding bytes (fields "_"). My PCD reader did not expected those thing previously. I modified the code to address those fields, and the code should work now. |
map/autoware_pointcloud_divider/launch/pointcloud_divider.launch.py
Outdated
Show resolved
Hide resolved
map/autoware_pointcloud_divider/docs/how_to_be_downsampled.drawio.svg
Outdated
Show resolved
Hide resolved
map/autoware_pointcloud_divider/docs/output_file_name_pattern.drawio.svg
Outdated
Show resolved
Hide resolved
map/autoware_pointcloud_merger/launch/pointcloud_merger.launch.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Anh Nguyen <[email protected]>
Signed-off-by: Anh Nguyen <[email protected]>
Description
Tests performed
Notes for reviewers
"point_xyz"
or"point_xyzi"
(string type).Interface changes
ros2 launch
instead of shell scripts like MapIV's tools.Effects on system behavior
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.