Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): suppress reseting root lanelet #9129

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 21, 2024

Description

suppress reseting root lanelet.

root lanelet is not updated when

  • receiving same uuid route (e.g. rerouting with modifiled goal )
  • failing getting closest lanelet while any approved module is running

Related links

Parent Issue:

  • Link

How was this PR tested?

2024/10/21 https://evaluation.tier4.jp/evaluation/reports/698116ac-225c-5427-9e03-ada876229a76/?project_id=prd_jt

before

lc_avoid_goal-2024-10-17_11.18.37.mp4

after

avoidance_pull_over-2024-10-21_20.11.39.mp4
avoidance_pull_over-2024-10-21_19.43.54.mp4

I also checked that root lanelet update when lc -> pull over

lc_pull_over-2024-10-21_19.57.04.mp4

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (06adbc4) to head (52961d2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...or_path_planner/src/behavior_path_planner_node.cpp 0.00% 1 Missing ⚠️
...ware_behavior_path_planner/src/planner_manager.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9129      +/-   ##
==========================================
- Coverage   28.26%   28.25%   -0.02%     
==========================================
  Files        1306     1312       +6     
  Lines      101091   101136      +45     
  Branches    39243    39245       +2     
==========================================
- Hits        28573    28572       -1     
- Misses      69761    69807      +46     
  Partials     2757     2757              
Flag Coverage Δ *Carryforward flag
differential 17.08% <50.00%> (?)
total 28.26% <ø> (-0.01%) ⬇️ Carriedforward from 06adbc4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -135,7 +135,7 @@ BehaviorModuleOutput PlannerManager::run(const std::shared_ptr<PlannerData> & da
const bool is_any_module_running =
is_any_approved_module_running || is_any_candidate_module_running_or_idle;

updateCurrentRouteLanelet(data);
updateCurrentRouteLanelet(data, is_any_approved_module_running);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if is_any_approved_module_running, then when the ego path is on the middle of two lanes while avoiding, ReferencePath can suddenly switch to the next lane. To prevent it, while modules are running, do not call this (resetCurrentRouteLanelet is called when lane_change successfully finished.)

@kosuke55
Copy link
Contributor Author

@satoshi-ota could you please check code owner?

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants