Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(evaluator): missing dependency in evaluator components #9074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

f0reachARR
Copy link
Contributor

Description

This PR add / modify dependencies written in package.xml.
The changed dependencies are almost about ament_index_cpp.
Jazzy has a build error due to not having a dependency on ament_index_cpp.
We have found similar errors in other ROS packages and have confirmed that they are not specific to the author's environment.

Related links

Reference: #7598
Base pull request: #7600

How was this PR tested?

colcon test passed.
This PR does not change the behavior of Autoware.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) label Oct 10, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@HansRobo HansRobo enabled auto-merge (squash) October 10, 2024 09:30
@HansRobo HansRobo added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.95%. Comparing base (b93ddd9) to head (c7b86ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9074      +/-   ##
==========================================
- Coverage   26.95%   26.95%   -0.01%     
==========================================
  Files        1297     1299       +2     
  Lines       95780    95808      +28     
  Branches    39136    39139       +3     
==========================================
+ Hits        25820    25824       +4     
- Misses      67370    67395      +25     
+ Partials     2590     2589       -1     
Flag Coverage Δ *Carryforward flag
differential 20.04% <ø> (?)
total 26.95% <ø> (ø) Carriedforward from b93ddd9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f0reachARR
Copy link
Contributor Author

Could you review this PR?
@kyoichi-sugahara @TakaHoribe @kminoda (Code owners)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants