-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace artifactory by minio for public repo #450
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR replaces Artifactory with MinIO/S3 as the default backend for public repositories. The implementation maintains backward compatibility with Artifactory while introducing S3 and MinIO support. The changes primarily involve updating repository configurations, backend handling, and test fixtures to use the new S3-based public repository. Updated class diagram for Repository classclassDiagram
class Repository {
+FileSystem file-system
+Minio minio
+Artifactory artifactory
+create_backend_interface() Type
}
note for Repository "Artifactory is included only if available in audbackend.backend"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Requires audeering/audbackend#231.
Adds support for S3 and MinIO backends, and switches the default repository to one hosted on AWS S3. It continues to support Artifactory backends.
Summary by Sourcery
Replace Artifactory with MinIO for public repositories, adding support for S3 and MinIO backends while maintaining compatibility with Artifactory.
New Features:
Enhancements: