Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace artifactory by minio for public repo #450

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Replace artifactory by minio for public repo #450

wants to merge 2 commits into from

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Oct 30, 2024

Requires audeering/audbackend#231.

Adds support for S3 and MinIO backends, and switches the default repository to one hosted on AWS S3. It continues to support Artifactory backends.

Summary by Sourcery

Replace Artifactory with MinIO for public repositories, adding support for S3 and MinIO backends while maintaining compatibility with Artifactory.

New Features:

  • Add support for S3 and MinIO backends.

Enhancements:

  • Switch the default repository to one hosted on AWS S3.

@hagenw hagenw marked this pull request as draft October 30, 2024 14:08
Copy link

sourcery-ai bot commented Oct 30, 2024

Reviewer's Guide by Sourcery

This PR replaces Artifactory with MinIO/S3 as the default backend for public repositories. The implementation maintains backward compatibility with Artifactory while introducing S3 and MinIO support. The changes primarily involve updating repository configurations, backend handling, and test fixtures to use the new S3-based public repository.

Updated class diagram for Repository class

classDiagram
    class Repository {
        +FileSystem file-system
        +Minio minio
        +Artifactory artifactory
        +create_backend_interface() Type
    }
    note for Repository "Artifactory is included only if available in audbackend.backend"
Loading

File-Level Changes

Change Details Files
Added support for MinIO/S3 backends and updated backend registry
  • Added MinIO backend to the backend registry
  • Made Artifactory backend conditional based on availability
  • Updated backend interface creation logic to handle different backend types
audb/core/repository.py
Updated repository configuration and constants
  • Added new constants for S3 public host and backend
  • Updated default repository configuration to use MinIO backend
  • Changed repository names from 'data-public' to 'audb-public'
tests/conftest.py
audb/core/etc/audb.yaml
Modified database operations to handle S3/MinIO backend
  • Updated available() function to work with new backend
  • Modified versions() function to handle backend-specific operations
  • Updated example outputs to reflect new backend configuration
audb/core/api.py
Updated test fixtures and documentation
  • Modified repository fixtures to use new S3 backend
  • Updated documentation strings to remove Artifactory-specific references
  • Adjusted test configurations for private and public repositories
tests/conftest.py
audb/core/conftest.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant