Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audb.available() for S3 / Minio backends #464

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix audb.available() for S3 / Minio backends #464

merged 1 commit into from
Nov 18, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Nov 18, 2024

This fixes the code introduced in #458 for S3/Minio backends and audb.available().

We still cannot add a test for it, this will be done later when we are ready for #450.

Summary by Sourcery

Bug Fixes:

  • Fix the handling of object names in S3 and Minio backends by removing trailing slashes to ensure correct path formation.

Copy link
Contributor

sourcery-ai bot commented Nov 18, 2024

Reviewer's Guide by Sourcery

The PR fixes the audb.available() functionality for S3/MinIO backends by correcting the object name handling and path construction in the list operations. The changes ensure proper traversal of database versions in S3/MinIO storage structures.

Sequence diagram for S3/MinIO object listing in audb.available()

sequenceDiagram
    participant User
    participant audb as audb.available()
    participant Backend
    participant S3MinIO as S3/MinIO

    User->>audb: Call audb.available()
    audb->>Backend: Initialize backend client
    Backend->>S3MinIO: list_objects(repository.name)
    S3MinIO-->>Backend: Return object list
    Backend->>audb: Process object names
    audb->>Backend: list_objects(repository.name, f"{name}/")
    Backend->>S3MinIO: List objects with prefix
    S3MinIO-->>Backend: Return versioned object list
    Backend->>audb: Process versioned object names
    audb-->>User: Return available databases
Loading

File-Level Changes

Change Details Files
Fix S3/MinIO object listing and path handling
  • Remove trailing slash from object name when processing database names
  • Add explicit forward slash when listing objects for version detection
  • Improve path construction for header file detection
audb/core/api.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hagenw - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hagenw hagenw merged commit 269cf68 into main Nov 18, 2024
8 checks passed
@hagenw hagenw deleted the fix-available branch November 18, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant