Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [Modernize] Update project to use modern gradle practices #29

Closed
wants to merge 3 commits into from

Conversation

Nava2
Copy link
Collaborator

@Nava2 Nava2 commented Apr 21, 2023

This PR is a WIP and many small ones should be extracted from it

Related to #17, this PR updates the code base in the following ways:

The code was also incredibly complicated for what should be simple using modern Gradle patterns. This modernizes the patterns to use kotlin as that is the recommendedway to write gradle plugins today.
@Nava2 Nava2 linked an issue Apr 21, 2023 that may be closed by this pull request
…set specific *only*

This removes the complicated "global" options in favour of a simpler "source-set" specific set of options intead.

This was extracted as part of a refactor to update this project to use modern gradle paradigms. Extracted from #29.
* Source Set implementation used to allow definition within the JavaPlugin's
* Source sets. This does not extend [SourceSet].
*/
interface AssertJGeneratorSourceSet {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

Nava2 added a commit that referenced this pull request Apr 22, 2023
#30)

* [Simplification] Remove global options in plugin in favour of source-set specific *only*

This removes the complicated "global" options in favour of a simpler "source-set" specific set of options intead.

This was extracted as part of a refactor to update this project to use modern gradle paradigms. Extracted from #29.

* update README.md to reflect removal of global settings
Nava2 added a commit that referenced this pull request Apr 22, 2023
…#31)

This flattens the `DefaultAssertJGeneratorOptions` into a single class `AssertJGeneratorOptions` as the "Default" version was always used. This greatly simplifies the code and removes the strangely existing `java` `interface` that remained.

Extracted from #29 without `Konvert` yet.
Nava2 added a commit that referenced this pull request Apr 23, 2023
Nava2 added a commit that referenced this pull request Apr 23, 2023
This adds unidirectional Kotlin support for writing code in Kotlin and using it in Groovy.

Extracted from #29
Nava2 added a commit that referenced this pull request Apr 23, 2023
This removes a *lot* of groovy magic to make dynamic types work. Instead, we use a simple type constructed of two values. This type is then mapped to either a template string or a file and used as task input.

Extracted from #29. Depends on #37.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This adds unidirectional Kotlin support for writing code in Kotlin and using it in Groovy.

Extracted from #29
Nava2 added a commit that referenced this pull request Apr 23, 2023
This removes a *lot* of groovy magic to make dynamic types work. Instead, we use a simple type constructed of two values. This type is then mapped to either a template string or a file and used as task input.

Extracted from #29. Depends on #37.
Nava2 added a commit that referenced this pull request Apr 23, 2023
Nava2 added a commit that referenced this pull request Apr 23, 2023
…pler type (#38)

This removes a *lot* of groovy magic to make dynamic types work. Instead, we use a simple type constructed of two values. This type is then mapped to either a template string or a file and used as task input.

Extracted from #29. Depends on #37.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This has some small clean-ups before running Konvert on the EntryPointOptions type.

Extracted from #29
Nava2 added a commit that referenced this pull request Apr 23, 2023
This has some small clean-ups before running Konvert on the EntryPointOptions type.

Extracted from #29
Nava2 added a commit that referenced this pull request Apr 23, 2023
This has some small clean-ups before running Konvert on the EntryPointOptions type.

Extracted from #29
Nava2 added a commit that referenced this pull request Apr 23, 2023
This is a straight conversion with no functionality changes.

Extracted from #29.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This is a straight conversion with no functionality changes.

Extracted from #29.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This does a direct conversion from Groovy -> `Kotlin`. There are zero functional changes.

Depends on #39, extracted from #29.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This is a straight conversion with no functionality changes.

Extracted from #29.
Nava2 added a commit that referenced this pull request Apr 23, 2023
 This is a straight conversion to Kotlin with no behaviour changes.

Extracted from #29.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This is a straight conversion with no functionality changes.

Extracted from #29.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This cleans up the code paths that will eventually be Konverted. This also properly sets up the input annotations to for caching/up-to-date checking.

Extracted from #29/#43.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This cleans up the code paths that will eventually be Konverted. This also properly sets up the input annotations to for caching/up-to-date checking.

Extracted from #29/#43.
Nava2 added a commit that referenced this pull request Apr 23, 2023
#44)

This cleans up the code paths that will eventually be Konverted. This also properly sets up the input annotations to for caching/up-to-date checking.

Extracted from #29/#43.
Nava2 added a commit that referenced this pull request Apr 23, 2023
 This is a straight conversion to Kotlin with no behaviour changes.

Extracted from #29.
Nava2 added a commit that referenced this pull request Apr 23, 2023
This is a straight conversion to Kotlin with no behaviour changes.

Extracted from #29.
@Nava2 Nava2 closed this Apr 29, 2023
@Nava2 Nava2 deleted the kevin/rewrite-in-kotlin branch April 29, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for newer Gradle versions
1 participant