Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Konvert] Convert AssertJGenerationTask to Kotlin #43

Merged
merged 2 commits into from
Apr 23, 2023
Merged

[Konvert] Convert AssertJGenerationTask to Kotlin #43

merged 2 commits into from
Apr 23, 2023

Conversation

Nava2
Copy link
Collaborator

@Nava2 Nava2 commented Apr 23, 2023

This is a straight conversion to Kotlin with no behaviour changes.

Extracted from #29.

Nava2 added a commit that referenced this pull request Apr 23, 2023
@Nava2
[Clean-up] Clean-up some groovy code for the AssertJ task, add caching
0e2c483 
This cleans up the code paths that will eventually be Konverted. This also properly sets up the input annotations to for caching/up-to-date checking.

Extracted from #29/#43.
@Nava2 Nava2 mentioned this pull request Apr 23, 2023
Merged
Nava2 added a commit that referenced this pull request Apr 23, 2023
@Nava2
[Clean-up] Clean-up some groovy code for the AssertJ task, add caching
d130fac 
This cleans up the code paths that will eventually be Konverted. This also properly sets up the input annotations to for caching/up-to-date checking.

Extracted from #29/#43.
Nava2 added a commit that referenced this pull request Apr 23, 2023
@Nava2
[Clean-up] Clean-up some groovy code for the AssertJ task, add caching (
a4a47d2 
#44)

This cleans up the code paths that will eventually be Konverted. This also properly sets up the input annotations to for caching/up-to-date checking.

Extracted from #29/#43.
@Nava2
[Konvert] Convert AssertJGenerationTask to Kotlin
4596747 
 This is a straight conversion to Kotlin with no behaviour changes.

Extracted from #29.
@Nava2 Nava2 force-pushed the kevin/konvert-assertj-task branch from e4445f1 to 4596747 Compare April 23, 2023 21:05
@Nava2 Nava2 marked this pull request as ready for review April 23, 2023 21:06
@Nava2 Nava2 merged commit 95dd7f6 into main Apr 23, 2023
@Nava2 Nava2 deleted the kevin/konvert-assertj-task branch April 23, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nava2