[Simplify] Clean-up report builder to make it easier to read and prep… #35
Conversation
…are for konvert Extracted from #29
| File directoryPathWhereAssertionFilesAreGenerated | ||
| Collection<String> inputPackages | ||
| Collection<String> inputClasses | ||
| Exception exception | ||
| Collection<TypeToken<?>> excludedClassesFromAssertionGeneration | ||
| final List<String> userTemplates | ||
| final Set<String> inputClassesNotFound |
There was a problem hiding this comment.
All of these replace needless get() methods
| private Collection<TypeToken<?>> excludedClassesFromAssertionGeneration | ||
| private Set<String> inputClassesNotFound | ||
| private List<String> userTemplates | ||
| private static final String Line = System.lineSeparator() |
There was a problem hiding this comment.
this makes the append(Line) easier to read than append(System.lineSeparator())
| reportBuilder.append(INDENT).append("Given classes : ").append(Arrays.toString(inputClasses)) | ||
| reportBuilder.append(System.lineSeparator()) | ||
| } | ||
| if (isNotEmpty(inputPackages as String[])) { |
There was a problem hiding this comment.
These incantations were replaced with !field?.isEmpty() which groovy coaleces null -> false and is much easier to grep.
| @@ -17,24 +17,25 @@ import org.assertj.assertions.generator.AssertionsEntryPointType | |||
|
|
|||
| import static com.google.common.collect.Maps.newTreeMap | |||
| import static com.google.common.collect.Sets.newTreeSet | |||
| import static org.apache.commons.lang3.ArrayUtils.isNotEmpty | |||
| import static org.apache.commons.lang3.StringUtils.remove | |||
| import static org.apache.commons.lang3.exception.ExceptionUtils.getStackTrace | |||
|
|
|||
| class AssertionsGeneratorReport { | |||
There was a problem hiding this comment.
Review this with whitespace checks off, it's much more obvious what I changed.
| reportBuilder.append("No custom assertions files generated for the following input classes as they were not found:\n") | ||
| for (String inputClassNotFound : inputClassesNotFound) { | ||
| reportBuilder.append(INDENT).append(inputClassNotFound).append(System.lineSeparator()) | ||
| new StringBuilder().tap { |
There was a problem hiding this comment.
The tap method is identical to Kotlin's apply. Ideally, I would rewrite the methods that add more content as Extension functions, but we can't because Groovy has a limitation where extensions can only be static and defined on separate objects. More or less a needless limitation from a language standpoint, but I'm sure there's a reason technically. Kotlin doesn't have this limitation 👍🏻
…are for konvert
Extracted from #29