Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NEQ to lie_group_base (Issue #316) #318

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from

Conversation

MarshallVielmetti
Copy link

See Issue #316

Added NEQ operator overload to lie_group_base and some tests.

@artivis
Copy link
Owner

artivis commented Jan 25, 2025

Hi, thanks for the contribution!

Would you kindly add:

  • the inequality operator to the TangentBase class (see here) so that it is at parity with the LieGroupBase.
  • a couple 'expect's to the template test so that all groups/tangents are covered by the test? You can add them directly in the existing evalIsApprox test (see here).

I'll look at the failing tests as they are currently failing for reasons unrelated to this pr.

@MarshallVielmetti
Copy link
Author

Of course--should be updated!

@artivis
Copy link
Owner

artivis commented Jan 27, 2025

Thanks for the update 👍 .
I'll merge this PR once I get #319 through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants