This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
fix: Using settings.base_url to setup base url path
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
frascuchon
changed the title
settings.base_url to setup base url path
jfcalvo
reviewed
Feb 5, 2024
for more information, see https://pre-commit.ci
jfcalvo
approved these changes
Feb 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 90.13% 90.14%
=======================================
Files 187 187
Lines 9178 9190 +12
=======================================
+ Hits 8273 8284 +11
- Misses 905 906 +1 ☔ View full report in Codecov by Sentry. |
frascuchon
added a commit
that referenced
this pull request
Feb 6, 2024
…ARGILLA_BASE_URL enabled This fix is related to work developed in #14 This change is still compatible with a proxied configuration
frascuchon
added a commit
that referenced
this pull request
Feb 7, 2024
…e `ARGILLA_BASE_URL` enabled (#19) This fix is related to work developed in #14 This change is still compatible with a proxied configuration. To make it work using an nginx proxy configuration as defined [here](https://github.com/argilla-io/argilla/blob/develop/docker/nginx/nginx.conf), you should adapt the target server to adding the configured base URL: ```conf events {} http { server { listen 80; location /argilla/ { proxy_pass http://argilla:6900/argilla; # <- this line adds the `/argilla` path proxy_set_header Host $host; proxy_set_header X-Real-IP $remote_addr; proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; proxy_set_header X-Forwarded-Proto $scheme; } } } ```
frascuchon
added a commit
that referenced
this pull request
Feb 8, 2024
Otherwise, the SPA flow when loading the application from a shared URL This error was introduced in this [PR](#14)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes to allow configuring a base path using
ARGILLA_BASE_URLwithout requiring an external proxy.If you want to run argilla behind a proxy without changing base URL (which means defining a pathRewrite rule in your proxy), you should use the
UVICORN_ROOT_PATHenv variable. For more info visit https://fastapi.tiangolo.com/advanced/behind-a-proxy/#behind-a-proxy and https://www.uvicorn.org/settings/Related PR: argilla-io/argilla#3543
Closes argilla-io/argilla#4568
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)