Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Commit

Permalink
fix: remove --root-path param when running the docker image with the …
Browse files Browse the repository at this point in the history
…ARGILLA_BASE_URL enabled

This fix is related to work developed in #14

This change is still compatible with a proxied configuration
  • Loading branch information
frascuchon committed Feb 6, 2024
1 parent 498a979 commit 103c452
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
6 changes: 1 addition & 5 deletions docker/quickstart/scripts/start_quickstart_argilla.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,4 @@ python load_data.py "$OWNER_API_KEY" "$LOAD_DATASETS" &

# Start Argilla
echo "Starting Argilla"
if [ -n "$ARGILLA_BASE_URL" ]; then
uvicorn argilla_server:app --host "0.0.0.0" --root-path "$ARGILLA_BASE_URL"
else
uvicorn argilla_server:app --host "0.0.0.0"
fi
python -m uvicorn argilla_server:app --host "0.0.0.0"
8 changes: 1 addition & 7 deletions docker/server/scripts/start_argilla_server.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,4 @@ fi
# with the prefix UVICORN_. For example, in case you want to
# run the app on port 5000, just set the environment variable
# UVICORN_PORT to 5000.

# Check for ARGILLA_BASE_URL and add --root-path if present
if [ -n "$ARGILLA_BASE_URL" ]; then
python -m uvicorn argilla_server:app --host "0.0.0.0" --root-path "$ARGILLA_BASE_URL"
else
python -m uvicorn argilla_server:app --host "0.0.0.0"
fi
python -m uvicorn argilla_server:app --host "0.0.0.0"

0 comments on commit 103c452

Please sign in to comment.