Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail if downloaded file has good checksum but incorrect size. #2739

Merged
merged 3 commits into from
Oct 28, 2024

Added integration test

ea7391f
Select commit
Loading
Failed to load commit list.
Merged

Do not fail if downloaded file has good checksum but incorrect size. #2739

Added integration test
ea7391f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 28, 2024 in 0s

67.63% (target 30.00%)

View this Pull Request on Codecov

67.63% (target 30.00%)

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.63%. Comparing base (2dcee40) to head (ea7391f).

Files with missing lines Patch % Lines
internal/arduino/resources/checksums.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2739      +/-   ##
==========================================
- Coverage   67.63%   67.63%   -0.01%     
==========================================
  Files         237      237              
  Lines       22356    22354       -2     
==========================================
- Hits        15121    15119       -2     
  Misses       6046     6046              
  Partials     1189     1189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.