Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: removing a lot of duplicated/dead code #2282

Merged
merged 15 commits into from
Aug 29, 2023

Inlined TXTBuildRulesHaveChanged function

22dcc9e
Select commit
Loading
Failed to load commit list.
Merged

legacy: removing a lot of duplicated/dead code #2282

Inlined TXTBuildRulesHaveChanged function
22dcc9e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 28, 2023 in 0s

63.33% (target 30.00%)

View this Pull Request on Codecov

63.33% (target 30.00%)

Details

Codecov Report

Patch coverage: 38.58% and project coverage change: +0.27% 🎉

Comparison is base (a47e35f) 63.06% compared to head (22dcc9e) 63.33%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
+ Coverage   63.06%   63.33%   +0.27%     
==========================================
  Files         221      219       -2     
  Lines       19771    19536     -235     
==========================================
- Hits        12469    12374      -95     
+ Misses       6195     6078     -117     
+ Partials     1107     1084      -23     
Files Changed Coverage Δ
legacy/builder/create_cmake_rule.go 8.30% <6.14%> (-0.79%) ⬇️
legacy/builder/test/helper_tools_downloader.go 60.80% <16.66%> (+5.17%) ⬆️
...der/wipeout_build_path_if_build_options_changed.go 78.84% <40.00%> (-5.16%) ⬇️
legacy/builder/phases/core_builder.go 71.55% <69.56%> (-2.74%) ⬇️
legacy/builder/builder_utils/utils.go 72.03% <71.42%> (+2.09%) ⬆️
legacy/builder/container_find_includes.go 71.52% <71.42%> (-0.41%) ⬇️
legacy/builder/types/types.go 85.71% <88.00%> (+5.71%) ⬆️
legacy/builder/utils/utils.go 89.24% <100.00%> (+43.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.