-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
legacy: removing a lot of duplicated/dead code #2282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will not break the CMake generator but will remove the CopyDir implementation from the public API space.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2282 +/- ##
==========================================
+ Coverage 63.06% 63.33% +0.27%
==========================================
Files 221 219 -2
Lines 19771 19536 -235
==========================================
- Hits 12469 12374 -95
+ Misses 6195 6078 -117
+ Partials 1107 1084 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
cmaglie
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Aug 28, 2023
alessio-perugini
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
Some refactorings of the
legacy
builder (a lot of code duplication removed).What is the current behavior?
No changes
What is the new behavior?
No changes
Does this PR introduce a breaking change, and is titled accordingly?
Other information