Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: removing a lot of duplicated/dead code #2282

Merged
merged 15 commits into from
Aug 29, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Aug 28, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Some refactorings of the legacy builder (a lot of code duplication removed).

What is the current behavior?

No changes

What is the new behavior?

No changes

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 38.58% and project coverage change: +0.27% 🎉

Comparison is base (a47e35f) 63.06% compared to head (22dcc9e) 63.33%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
+ Coverage   63.06%   63.33%   +0.27%     
==========================================
  Files         221      219       -2     
  Lines       19771    19536     -235     
==========================================
- Hits        12469    12374      -95     
+ Misses       6195     6078     -117     
+ Partials     1107     1084      -23     
Flag Coverage Δ
unit 63.33% <38.58%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
legacy/builder/create_cmake_rule.go 8.30% <6.14%> (-0.79%) ⬇️
legacy/builder/test/helper_tools_downloader.go 60.80% <16.66%> (+5.17%) ⬆️
...der/wipeout_build_path_if_build_options_changed.go 78.84% <40.00%> (-5.16%) ⬇️
legacy/builder/phases/core_builder.go 71.55% <69.56%> (-2.74%) ⬇️
legacy/builder/builder_utils/utils.go 72.03% <71.42%> (+2.09%) ⬆️
legacy/builder/container_find_includes.go 71.52% <71.42%> (-0.41%) ⬇️
legacy/builder/types/types.go 85.71% <88.00%> (+5.71%) ⬆️
legacy/builder/utils/utils.go 89.24% <100.00%> (+43.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cmaglie cmaglie marked this pull request as ready for review August 28, 2023 15:11
@cmaglie cmaglie self-assigned this Aug 28, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 28, 2023
@cmaglie cmaglie merged commit 3f9373a into arduino:master Aug 29, 2023
89 checks passed
@cmaglie cmaglie deleted the remove_dead_code branch August 29, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants