Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added http to allowedProtocols, Added local contract addresses to constants.ts #302

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Added http to allowedProtocols, Added local contract addresses to constants.ts #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions modules/client-common/src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,17 +375,17 @@ export const LIVE_CONTRACTS: {
ensRegistryAddress: activeContractsList.baseGoerli.ENSRegistry,
},
[SupportedNetwork.LOCAL]: {
daoFactoryAddress: "",
pluginSetupProcessorAddress: "",
multisigRepoAddress: "",
adminRepoAddress: "",
addresslistVotingRepoAddress: "",
tokenVotingRepoAddress: "",
multisigSetupAddress: "",
adminSetupAddress: "",
addresslistVotingSetupAddress: "",
tokenVotingSetupAddress: "",
ensRegistryAddress: "",
daoFactoryAddress: "0x4ed7c70F96B99c776995fB64377f0d4aB3B0e1C1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definetly not the ideal solution harcoding a bunch of addresses in the sdk. Yo can overrid tthis addresses when you pass the context params

pluginSetupProcessorAddress: "0x59b670e9fA9D0A427751Af201D676719a970857b",
multisigRepoAddress: "0xD235571A8ED990638699d87c1e7527F576C91aB7",
adminRepoAddress: "0x8755D348E575Fc4a68EC5d0B609BC7c070ebeA3d",
addresslistVotingRepoAddress: "0x624dC0EcEFD94640D316eE3ACfD147Ed9B764638",
tokenVotingRepoAddress: "0x94cD1b4DeA480E09A1e0d83f6C92b9A5C6136171",
multisigSetupAddress: "0xc3e53F4d16Ae77Db1c982e75a937B9f60FE63690",
adminSetupAddress: "0xE6E340D132b5f46d1e472DebcD681B2aBc16e57E",
addresslistVotingSetupAddress: "0x7a2088a1bFc9d81c55368AE168C2C02570cB814F",
tokenVotingSetupAddress: "0x67d269191c92Caf3cD7723F116c85e6E9bf55933",
ensRegistryAddress: "0xDc64a140Aa3E981100a9becA4E685f962f0cF6C9",
},
[SupportedNetwork.SEPOLIA]: {
daoFactoryAddress: activeContractsList.sepolia.DAOFactory,
Expand Down
2 changes: 1 addition & 1 deletion modules/client-common/src/context-core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
} from "./errors";

const DEFAULT_GAS_FEE_ESTIMATION_FACTOR = 0.625;
const supportedProtocols = ["https:"];
const supportedProtocols = ["https:", "http:"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add ths i would delete the next lines because they wouldnt makes sense anymore

if (typeof process !== "undefined" && process?.env?.TESTING) {
supportedProtocols.push("http:");
}
Expand Down