Added http to allowedProtocols, Added local contract addresses to constants.ts #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
josemarinas
reviewed
Nov 22, 2023
| addresslistVotingSetupAddress: "", | ||
| tokenVotingSetupAddress: "", | ||
| ensRegistryAddress: "", | ||
| daoFactoryAddress: "0x4ed7c70F96B99c776995fB64377f0d4aB3B0e1C1", |
There was a problem hiding this comment.
Definetly not the ideal solution harcoding a bunch of addresses in the sdk. Yo can overrid tthis addresses when you pass the context params
josemarinas
reviewed
Nov 22, 2023
| @@ -22,7 +22,7 @@ import { | |||
| } from "./errors"; | |||
|
|
|||
| const DEFAULT_GAS_FEE_ESTIMATION_FACTOR = 0.625; | |||
| const supportedProtocols = ["https:"]; | |||
| const supportedProtocols = ["https:", "http:"]; | |||
There was a problem hiding this comment.
If we add ths i would delete the next lines because they wouldnt makes sense anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist:
CHANGELOG.mdfile in the root folder of the package after the[UPCOMING]title and before the latest version.