ROVER-279 Funnels Errors from Supergraph Config Deserialisation to LSP #2345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 37742f44ef350d29f9e81f90 |
jonathanrainer
force-pushed
the
jr/task/ROVER-245
branch
3 times, most recently
from
dcaa3a6 to
487336e
Compare
aaronArinder
approved these changes
Jan 15, 2025
src/command/lsp/mod.rs
Outdated
| FsWriteFile::default(), | ||
| client_config.service()?, | ||
| fetch_remote_subgraph_factory.boxed_clone(), | ||
| 1, |
There was a problem hiding this comment.
worth being a const? what does this 1 represent, threads or something?
There was a problem hiding this comment.
So it's the retry interval for introspection, but this is actually fixed in the ROVER-245 PR because it gets turned into a command line option, which is a lot clearer anyway!
jonathanrainer
force-pushed
the
jr/task/ROVER-245
branch
from
487336e to
15a3c47
Compare
In order to route errors properly to the LSP we need to introduce a new type of subtask which can broadcast out to multiple receivers. This we have done, and have thus had to implement a few changes to other underlying infrastructure, but not too much.
This probably needs renaming but the idea is that this is also watching events that come from watching the SupergraphConfig and will also react to them.
The handling is rudimentary at the minute, but it surfaces errors properly, which is the key
jonathanrainer
force-pushed
the
jr/task/ROVER-279
branch
from
f61a812 to
ccc374d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS CANNOT BE MERGED UNTIL ROVER-245 HAS
So the key observation here is that the LSP needs to get back the details of errors that occur when we try and deserialise the Supergraph YAML and before this it didn't, those errors were simply printed into the DEBUG logs and then thrown away. In order to do this I've had to add a few more concepts into the work done on Subtasks etc. because in order to do this properly we need a Subtask that can send events across to multiple places (with broadcast semantics).
So the key changes in this PR follow the 3 commits:
.subscribe()method, which copies the interface of atokioBroadcastStream. This does have consequences for the kind of data you can send out of these subtasks (i.e. all the data has to be Cloneable) but as this is a specific use-case I see no issue with this.