Skip to content

Commit

Permalink
ROVER-245 Remove TODOs and fix up
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanrainer committed Jan 13, 2025
1 parent 1547f03 commit dcaa3a6
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/command/lsp/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ async fn run_lsp(client_config: StudioClientConfig, lsp_opts: LspOpts) -> RoverR
None => {
let (service, socket, _receiver) = ApolloLanguageServer::build_service(
Config {
// TODO Do we need to worry about these now?
root_uri: String::default(),
enable_auto_composition: false,
force_federation: false,
Expand Down Expand Up @@ -270,7 +269,7 @@ async fn start_composition(
}
CompositionEvent::Error(err) => {
debug!("Composition failed: {err}");
let message = format!("Failed run composition: {err}",);
let message = format!("Failed run composition: {err}");
let diagnostic = Diagnostic::new_simple(Range::default(), message);
language_server
.publish_diagnostics(supergraph_yaml_url.clone(), vec![diagnostic])
Expand Down

0 comments on commit dcaa3a6

Please sign in to comment.