Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ARM64 build binary and images #514

Closed
wants to merge 4 commits into from
Closed

Support ARM64 build binary and images #514

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b10a06
Support ARM64 binary in docker image
StLeoX Aug 18, 2024
ed92e8e
Merge branch 'main' into dev_support_arm64
hanahmily Aug 19, 2024
b12a72f
splits banyand/Makefile
StLeoX Aug 19, 2024
c167fa1
Merge remote-tracking branch 'origin/dev_support_arm64' into dev_supp…
StLeoX Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/publish-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ jobs:
run: |
GOOS=windows GOARCH=amd64 make -C banyand banyand-server-static
GOOS=windows GOARCH=amd64 make -C bydbctl build
- name: Build OSX binaries
run: |
GOOS=darwin GOARCH=arm64 make -C banyand banyand-server-static
GOOS=darwin GOARCH=arm64 make -C bydbctl build
Comment on lines +82 to +85
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this AARM or ARM? The CI name seems a little tricky.

- name: Build docker image
if: github.ref != 'refs/heads/main' # Only build docker image on PR(Push image when pushed to main branch)
run: |
Expand Down
3 changes: 2 additions & 1 deletion docs/installation/binaries.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,4 +97,5 @@ $ ls bydbctl/build/bin
bydbctl bydbctl--darwin-amd64 bydbctl--darwin-arm64 bydbctl--linux-386 bydbctl--linux-amd64 bydbctl--linux-arm64 bydbctl--windows-386 bydbctl--windows-amd64
```

> The build script now checks if the binary file exists before rebuilding. If you want to rebuild, please remove the binary file manually.
> 1. The build script now checks if the binary file exists before rebuilding. If you want to rebuild, please remove the binary file manually.
> 2. `make -C banyand release` will automatically match your OS and platform. If you run it on macOS, you will get the `banyand-server-static` binary for `darwin-arm64`.
Loading