Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM64 build binary and images #514

Closed
wants to merge 4 commits into from

Conversation

StLeoX
Copy link
Contributor

@StLeoX StLeoX commented Aug 18, 2024

Support ARM64 build binary and images

  • If this is non-trivial feature, paste the links/URLs to the design doc.
  • Update the documentation to include this new feature.
  • Tests(including UT, IT, E2E) are added to verify the new feature.
  • If it's UI related, attach the screenshots below.
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Fixes [Feature] Support ARM64 build binary and images skywalking#12308 .

@StLeoX StLeoX changed the title Support ARM64 build binary and images [ospp] Support ARM64 build binary and images Aug 18, 2024
Comment on lines +82 to +85
- name: Build OSX binaries
run: |
GOOS=darwin GOARCH=arm64 make -C banyand banyand-server-static
GOOS=darwin GOARCH=arm64 make -C bydbctl build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this AARM or ARM? The CI name seems a little tricky.

@wu-sheng wu-sheng added this to the 0.7.0 milestone Aug 18, 2024
@StLeoX
Copy link
Contributor Author

StLeoX commented Aug 18, 2024

Currently, I just add darwin-arm64 for docker publishing.

I wonder if we really need something like banyand-server-static-darwin-arm64 in the tar release. And the binaries list may be semilar with bydnctl ?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.52%. Comparing base (c3e4029) to head (4b10a06).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #514       +/-   ##
===========================================
+ Coverage   41.16%   51.52%   +10.35%     
===========================================
  Files         157      157               
  Lines       18963    18963               
===========================================
+ Hits         7807     9771     +1964     
+ Misses      10515     8415     -2100     
- Partials      641      777      +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wu-sheng
Copy link
Member

Currently, I just add darwin-arm64 for docker publishing.

I wonder if we really need something like banyand-server-static-darwin-arm64 in the tar release. And the binaries list may be semilar with bydnctl ?

darwin(aarm), we don't need this for official release. But we need Linux ARM as that, same for ctl.

The issue is referring these two things.

@lujiajing1126
Copy link
Contributor

lujiajing1126 commented Aug 19, 2024

Shall we consider goreleaser to build binaries and docker images?

@wu-sheng
Copy link
Member

We could consider this in a separate thread?

@StLeoX StLeoX marked this pull request as draft August 19, 2024 14:21
@wu-sheng
Copy link
Member

@hanahmily Please confirm whether this is the scope of this PR. Because in the end, we will need 3 images(linux intel, linux and, dawin) in GitHub image repo and first two in the DockerHub.

@hanahmily hanahmily changed the title [ospp] Support ARM64 build binary and images Support ARM64 build binary and images Aug 19, 2024
@hanahmily
Copy link
Contributor

The build system needs to be improved to support building multi-platform binaries, which is more complicated than I initially thought. I will address this issue. @StLeoX, I will leave you to your ospp project.

@hanahmily hanahmily closed this Aug 20, 2024
@StLeoX
Copy link
Contributor Author

StLeoX commented Aug 20, 2024

Fine

@StLeoX StLeoX deleted the dev_support_arm64 branch August 20, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support ARM64 build binary and images
5 participants