Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7614] Fix flaky test RocksDBMessageStoreTest #7625

Merged
merged 3 commits into from
Dec 11, 2023
+94 −76
Merged

[ISSUE #7614] Fix flaky test RocksDBMessageStoreTest #7625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
527afa2
fix #7614 Flaky test RocksDBMessageStoreTest
lizhanhui Dec 8, 2023
3709175
fix: give TimerMessageStoreTest#testStateAndRecover more time for Awa…
lizhanhui Dec 8, 2023
52f7a2d
clean up exclude test list of bazel
lizhanhui Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions store/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ java_library(
GenTestRules(
name = "GeneratedTestRules",
exclude_tests = [
# This test is extremely slow and flaky, exclude it.
# These tests are extremely slow and flaky, exclude them before they are properly fixed.
"src/test/java/org/apache/rocketmq/store/ha/autoswitch/AutoSwitchHATest",
"src/test/java/org/apache/rocketmq/store/RocksDBMessageStoreTest",
],
medium_tests = [
"src/test/java/org/apache/rocketmq/store/DefaultMessageStoreTest",
Expand All @@ -80,6 +79,7 @@ GenTestRules(
"src/test/java/org/apache/rocketmq/store/MappedFileQueueTest",
"src/test/java/org/apache/rocketmq/store/queue/BatchConsumeMessageTest",
"src/test/java/org/apache/rocketmq/store/dledger/MixCommitlogTest",
"src/test/java/org/apache/rocketmq/store/RocksDBMessageStoreTest",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

如果已经修复了，还需要exclude嘛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不是exclude，是定义medium size test: https://bazel.build/reference/test-encyclopedia#role-test-runner

],
test_files = glob(["src/test/java/**/*Test.java"]),
deps = [
Expand Down
Loading
Loading