[ISSUE #7614] Fix flaky test RocksDBMessageStoreTest #7625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lizhanhui <[email protected]>
lizhanhui
force-pushed
the
fix_flaky_test_7614
branch
from
73500e7 to
527afa2
Compare
lizhanhui
changed the title
…itability to poll and check Signed-off-by: lizhanhui <[email protected]>
Signed-off-by: lizhanhui <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #7625 +/- ##
=============================================
- Coverage 43.20% 43.17% -0.03%
+ Complexity 9796 9795 -1
=============================================
Files 1164 1164
Lines 84420 84428 +8
Branches 10961 10963 +2
=============================================
- Hits 36474 36456 -18
- Misses 43420 43446 +26
Partials 4526 4526 ☔ View full report in Codecov by Sentry. |
joeCarf
reviewed
Dec 11, 2023
| @@ -80,6 +79,7 @@ GenTestRules( | |||
| "src/test/java/org/apache/rocketmq/store/MappedFileQueueTest", | |||
| "src/test/java/org/apache/rocketmq/store/queue/BatchConsumeMessageTest", | |||
| "src/test/java/org/apache/rocketmq/store/dledger/MixCommitlogTest", | |||
| "src/test/java/org/apache/rocketmq/store/RocksDBMessageStoreTest", | |||
There was a problem hiding this comment.
这个不是exclude，是定义medium size test: https://bazel.build/reference/test-encyclopedia#role-test-runner
RongtongJin
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7614
Brief Description
How Did You Test This Change?
Verify there is no failures anymore.