Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241114) #7939

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241114) #7939

wants to merge 2 commits into from
+16 −8

Commits on Nov 13, 2024

  1. [GLUTEN-1632][CH]Daily Update Clickhouse Version (20241114)

    kyligence-git committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    56a589e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. Fix issues due to ClickHouse/ClickHouse#71539. 

    Issue 1
BuildQueryPipelineSettings is created manually instead of calling  BuildQueryPipelineSettings::fromContext(); so even ClickHouse/ClickHouse#71890 disable 'query_plan_merge_filters', UTs are still failed.

To fix  this issue, we need set correct default parameters in CHUtil.cpp

Issue 2
If we set query_plan_merge_filters to true, then ClickHouse/ClickHouse#71539 will try to split the left most AND atom to a separate DAG and hence create FilterTransformer for each And atom, which cause collecting metrics failed.

I am not sure the benefits of setting it to true, let's keep it to false.
    @baibaichen
    baibaichen committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    8c1fa24 View commit details
    Browse the repository at this point in the history