Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241114) #7939

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[GLUTEN-1632][CH]Daily Update Clickhouse Version (20241114) #7939

wants to merge 2 commits into from

Conversation

kyligence-git
Copy link
Contributor

Auto commit by gluten daily build, please check the build status and merge it if it's green.

@github-actions GitHub Actions
Copy link

#1632

@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

@baibaichen
Fix issues due to ClickHouse/ClickHouse#71539.
8c1fa24 
Issue 1
BuildQueryPipelineSettings is created manually instead of calling  BuildQueryPipelineSettings::fromContext(); so even ClickHouse/ClickHouse#71890 disable 'query_plan_merge_filters', UTs are still failed.

To fix  this issue, we need set correct default parameters in CHUtil.cpp

Issue 2
If we set query_plan_merge_filters to true, then ClickHouse/ClickHouse#71539 will try to split the left most AND atom to a separate DAG and hence create FilterTransformer for each And atom, which cause collecting metrics failed.

I am not sure the benefits of setting it to true, let's keep it to false.
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI on x86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLICKHOUSE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyligence-git @baibaichen