Includes a copy of publicsuffix.org's effective_tld_names.dat as a test fixture #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok2c
requested changes
Aug 23, 2024
garydgregory
force-pushed
the
5.4.x_copy_effective_tld_names.dat
branch
from
a848712
to
c9fd5a4
Compare
ok2c
approved these changes
Aug 24, 2024
ok2c
reviewed
Aug 24, 2024
https://publicsuffix.org/list/effective_tld_names.dat in httpclient5/src/test/resources/org/publicsuffix/list/effective_tld_names.dat Cleanly separate the concerns of which file to copy and whether to filter it or not by using two <resource> elements: - We want the .properties file copied and filtered. The git master version causes only the properties file to be copied, the .dat file is not copied. - We want to the .dat file copied but not filtered.
garydgregory
force-pushed
the
5.4.x_copy_effective_tld_names.dat
branch
from
c9fd5a4
to
46402a5
Compare
|
@garydgregory All looks good. Please go ahead and merge. |
@ok2c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes a copy of in https://publicsuffix.org/list/effective_tld_names.dat in
httpclient5/src/test/resources/org/publicsuffix/list/effective_tld_names.datOr, should this be a runtime resource?