Include Mozilla public suffix list file directly

[massdosage]

As discussed on the dev mailing list, this should fix the failing TestPublicSuffixMatcher tests on Windows.

[garydgregory]

Hello @massdosage

FWIW, Paths.get("mozilla", "public-suffix-list.txt").toString() would be better here but not really needed unless Paths where used in the test. The "/" does not matter in Java on or off Windows, Java normalizes the path for the platform.

The test set up is also problematic because it leaks a file handle. We should be using a try-with-resource here:

        // Create a matcher using a custom crafted public suffix list file
        try (InputStream in = classLoader.getResourceAsStream(SOURCE_FILE)) {
            Assertions.assertNotNull(in);
            final List<PublicSuffixList> lists = PublicSuffixListParser.INSTANCE.parseByType(new InputStreamReader(in, StandardCharsets.UTF_8));
            matcher = new PublicSuffixMatcher(lists);
        }

I fixed the above resource leak in git master.

The issue remains with the odd test failure on my end though :-(

[massdosage]

OK, the SOURCE_FILE code was already there before any of my changes so I purposefully didn't touch it but the try-with-resources you suggest looks good. Even if this PR doesn't fix the issue at least it will give a better error messages if the mozilla file wasn't downloaded.

I'm happy to make any changes you suggest here though.

[ok2c]

@massdosage That notation should work on all platforms. I am quite sure of it. This is not the right fix.

[massdosage]

OK, yeah, it's been ages since I touched Windows so I wasn't sure. In much earlier versions of Java this would have been an issue. If we instead prefer including the mozilla file in this repo like we do with SOURCE_FILE I can adjust this PR to do that instead?

[massdosage]

I've made that change here now.

[garydgregory]

Ah, this PR looks like a partial duplicate of #574 except that #574 preserves the ability to refresh the DAT file. Also this PR removes the download plugin from build section but it's still used from a profile.

[massdosage]

Feel free to close this one and use #574 instead.