Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-45293: [CI] Install patch command to base conda.dockerfile required in case of bundled ORC #45294

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jan 17, 2025

Rationale for this change

Patch command is required for bundled ORC.

What changes are included in this PR?

Adding patch to the based conda image.

Are these changes tested?

Yes via CI

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #45293 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Jan 17, 2025

@github-actions crossbow submit test-conda-python-emscripten

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Jan 17, 2025
Copy link

Revision: a80ceae

Submitted crossbow builds: ursacomputing/crossbow @ actions-e88155f3e7

Task Status
test-conda-python-emscripten GitHub Actions

@raulcd raulcd marked this pull request as ready for review January 17, 2025 14:14
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sorry. I missed this case...

@kou kou merged commit 61c82ea into apache:main Jan 18, 2025
37 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Jan 18, 2025
@github-actions github-actions bot added the awaiting merge Awaiting merge label Jan 18, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 61c82ea.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge Awaiting merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants