Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] test-conda-python-emscripten job fails due to missing patch command #45293

Closed
raulcd opened this issue Jan 17, 2025 · 1 comment
Closed

[CI] test-conda-python-emscripten job fails due to missing patch command #45293

raulcd opened this issue Jan 17, 2025 · 1 comment
Assignees
@raulcd
Labels
Component: Continuous Integration Type: bug
Milestone
20.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Jan 17, 2025

Describe the bug, including details regarding any error messages, version, and platform.

Since we merged:

We require the patch command to be present to patch ORC.

The test-conda-python-emscripten has been failing since that issue was closed with the following:

-- Building Apache ORC from source
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:4577 (find_program):
  Could not find PATCH using the following names: patch
Call Stack (most recent call first):
  cmake_modules/ThirdpartyToolchain.cmake:208 (build_orc)
  cmake_modules/ThirdpartyToolchain.cmake:311 (build_dependency)
  cmake_modules/ThirdpartyToolchain.cmake:4780 (resolve_dependency)
  CMakeLists.txt:546 (include)

Patch seems to be missing from that image.

Component(s)

Continuous Integration
raulcd added a commit to raulcd/arrow that referenced this issue Jan 17, 2025
@raulcd
apacheGH-45293: [CI] Install patch command to base conda.dockerfile r…
a80ceae 
…equired in case of bundled ORC
@github-actions github-actions bot mentioned this issue Jan 17, 2025
Merged
kou pushed a commit that referenced this issue Jan 18, 2025
@raulcd
GH-45293: [CI] Install patch command to base conda.dockerfile require…
61c82ea 
…d in case of bundled ORC (#45294)

### Rationale for this change

Patch command is required for bundled ORC.

### What changes are included in this PR?

Adding patch to the based conda image.

### Are these changes tested?

Yes via CI

### Are there any user-facing changes?

No

* GitHub Issue: #45293

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 20.0.0 milestone Jan 18, 2025
@kou
Copy link
Member

kou commented Jan 18, 2025

Issue resolved by pull request 45294
#45294

@kou kou closed this as completed Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Continuous Integration Type: bug
Projects
None yet
Milestone
20.0.0
Development

No branches or pull requests
2 participants
@kou @raulcd