sdk: Extract last-restart-slot crate #3272
Open
+62
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem Just about all of the sysvars have been extract in some way from solana-program, but the last restart slot sysvar has not. #### Summary of changes Following most of the other crates that have done this, move it out.
kevinheavey
reviewed
Oct 22, 2024
| @@ -493,7 +493,6 @@ pub mod incinerator; | |||
| pub mod instruction; | |||
| pub mod keccak; | |||
| pub mod lamports; | |||
| pub mod last_restart_slot; | |||
There was a problem hiding this comment.
looks like last_restart_slot.rs still needs to be deleted
There was a problem hiding this comment.
Ah right, thanks for noticing!
|
Looks good – there is only the nit that @kevinheavey mentioned. |
|
@yihau can you accept ownership of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Just about all of the sysvars have been extract in some way from solana-program, but the last restart slot sysvar has not.
Summary of changes
Following most of the other crates that have done this, move it out.