Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: Extract solana-sysvar crate #3309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joncinque
Copy link

Problem

The sysvars in solana-program are tightly coupled with types that exist in solana-program. For example, all of the special sysvar getters like Rent::get() are implemented through a macro that falls back to using program_stubs.

Because of this tight coupling, it's difficult to pull out bits for the sysvars.

Summary of changes

After numerous attempts, I've decided to keep it simple and only extract SysvarId, its helper macros, and get_sysvar.

To go along with that, all of the separated sysvar crates now implement the sysvar ids themselves under a new sysvar feature. This new feature might be overkill, so let me know if we should just include the sysvar ids by default. I went with a feature to include an implementation using the sol_get_sysvar syscall in the future.

It was really messy to include the Sysvar trait from solana-program because it falls back to using bincode, which we know performs poorly for on-chain programs. So the future idea is to create a new Sysvar trait in solana-sysvar which will require fewer bits to deserialize sysvars.

Let me know what you think about this PR and the future idea! Note that I'll need to rebase this on top of #3249 and #3272 when they land.

#### Problem

The sysvars in `solana-program` are tightly coupled with types that
exist in `solana-program`. For example, all of the special sysvar
getters like `Rent::get()` are implemented through a macro that falls
back to using `program_stubs`.

Because of this tight coupling, it's difficult to pull out bits for the
sysvars.

#### Summary of changes

After numerous attempts, I've decided to keep it simple and only extract
`SysvarId`, its helper macros, and `get_sysvar`.

To go along with that, all of the separated sysvar crates now implement
the sysvar ids themselves under a new `sysvar` feature. This new feature
might be overkill, so let me know if we should just include the sysvar
ids by default. I went with a feature to include an implementation using
the `sol_get_sysvar` syscall in the future.

It was really messy to include the `Sysvar` trait from `solana-program`
because it falls back to using `bincode`, which we know performs poorly
for on-chain programs. So the future idea is to create a new `Sysvar`
trait in `solana-sysvar` which will require fewer bits to deserialize
sysvars.

Let me know what you think about this PR and the future idea! Note that
I'll need to rebase this on top of solana-labs#3249 and solana-labs#3272 when they land.
@febo
Copy link

febo commented Oct 25, 2024

Maybe I missed something, but my current understanding is that we would still need to use both the sysvar specific crate + solana-program to get a sysvar. This is because impl_sysvar_get! still under solana-program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants