Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复排序菜单没有子节点时图标展示错误 & 调整默认样式 #2932

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Oct 22, 2024

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

🖼️ Screenshot

Before After
image image
image image

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 22, 2024 8:55am

@github-actions github-actions bot added the next 2.0-next 版本的问题 label Oct 22, 2024
@github-actions github-actions bot added the pr(fix) bug fix label Oct 22, 2024
@lijinke666 lijinke666 changed the title fix: 修复排序菜单没有子节点时图表展示错误 & 调整默认样式 fix: 修复排序菜单没有子节点时图标展示错误 & 调整默认样式 Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Size Change: -207 B (-0.06%)

Total Size: 329 kB

Filename Size Change
./packages/s2-react/dist/index.min.js 70.9 kB +9 B (+0.01%)
./packages/s2-react/dist/style.min.css 3.77 kB -106 B (-2.73%)
./packages/s2-vue/dist/style.min.css 1.85 kB -110 B (-5.62%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 229 kB
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-vue/dist/index.min.js 22.9 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Oct 22, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Oct 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (ecdc9c8) to head (8a4ad11).
Report is 453 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2932      +/-   ##
==========================================
+ Coverage   75.77%   80.83%   +5.06%     
==========================================
  Files         257      180      -77     
  Lines       11994    10426    -1568     
  Branches     2464     2365      -99     
==========================================
- Hits         9088     8428     -660     
+ Misses       1398      554     -844     
+ Partials     1508     1444      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo enabled auto-merge (squash) October 25, 2024 07:29
@wjgogogo wjgogogo merged commit da5ebfb into next Oct 25, 2024
8 of 9 checks passed
@wjgogogo wjgogogo deleted the fix-menu-style branch October 25, 2024 07:29
@lijinke666
Copy link
Member Author

🎉 This PR is included in version @antv/s2-react-v2.0.0-next.29 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix released on @next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants