Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复自定义菜单项不触发 click 事件的问题 #2946

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

lijinke666
Copy link
Member

👀 PR includes

🐛 Bugfix

  • Solve the issue and close #0

📝 Description

#2932 修复箭头的展示后, 由于层级发生变动, 原 sub-menu 变为 menu, 会导致自定义 menu 的 hook 未触发.

🖼️ Screenshot

Before After
Kapture 2024-10-28 at 17 03 35 Kapture 2024-10-28 at 17 01 41

🔗 Related issue link

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Oct 28, 2024 9:04am

@github-actions github-actions bot added pr(fix) bug fix next 2.0-next 版本的问题 labels Oct 28, 2024
Copy link
Contributor

Size Change: +24 B (+0.01%)

Total Size: 335 kB

Filename Size Change
./packages/s2-core/dist/index.min.js 236 kB -14 B (-0.01%)
./packages/s2-react/dist/index.min.js 70.9 kB +38 B (+0.05%)
ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/style.min.css 3.77 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.85 kB

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.79%. Comparing base (ecdc9c8) to head (7725bad).
Report is 465 commits behind head on next.

Files with missing lines Patch % Lines
...act/src/components/tooltip/components/operator.tsx 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2946      +/-   ##
==========================================
+ Coverage   75.77%   80.79%   +5.02%     
==========================================
  Files         257      180      -77     
  Lines       11994    10434    -1560     
  Branches     2464     2369      -95     
==========================================
- Hits         9088     8430     -658     
+ Misses       1398      556     -842     
+ Partials     1508     1448      -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lijinke666 lijinke666 merged commit 82dbb61 into next Oct 28, 2024
12 of 13 checks passed
@lijinke666 lijinke666 deleted the fix-menu-click-event branch October 28, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next 2.0-next 版本的问题 pr(fix) bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants