Use different dockerfile for docker-compose-build #13658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanCoding
reviewed
Mar 8, 2023
| DOCKER_BUILDKIT=1 docker build -t $(DEVEL_IMAGE_NAME) \ | ||
| --build-arg BUILDKIT_INLINE_CACHE=1 \ | ||
| --cache-from=$(DEV_DOCKER_TAG_BASE)/awx_devel:$(COMPOSE_TAG) . | ||
| docker-compose-build: Dockerfile.dev |
There was a problem hiding this comment.
Wouldn't this use a stale Dockerfile.dev unless you manually deleted it or touched it? That feels like it would inevitably give undesired behavior, since over time, people are almost sure to have a stale one around.
There was a problem hiding this comment.
that's how all the other Dockerfile target works,
since generating the Dockerfile is not very expensive what if we just turn all the Dockerfile targets PHONY? this way we avoid having the stale Dockerfile problem altogether
john-westcott-iv
approved these changes
Mar 8, 2023
TheRealHaoLiu
force-pushed
the
different-dockerfile
branch
from
a9b60cc
to
7e536b9
Compare
- use different dockerfile for awx_devel and awx image - make all Dockerfile* targets PHONY (bc its cheap to run) - fix HEADLESS not working for awx-kube-build
TheRealHaoLiu
force-pushed
the
different-dockerfile
branch
from
7e536b9
to
592920e
Compare
gamuniz
approved these changes
Apr 19, 2023
AlanCoding
approved these changes
Apr 19, 2023
|
I think my comment was addressed by having it added to .PHONY |
|
...hit the wrong button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
one of my previous commit turn Dockerfile to a PHONY make target, to avoid collision between
make docker-compose-buildandmake awx-kube-buildthis is a better approachISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION