-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] fix headless awx build #13745
[WIP] fix headless awx build #13745
Conversation
by adding make target that create fake static file dir so collectstatic wont fail when building in headless mode
# NOTE: The make target ui-next is imported from awx/ui_next/Makefile | ||
HEADLESS ?= no | ||
ifeq ($(HEADLESS), yes) | ||
dist/$(SDIST_TAR_FILE): | ||
dist/$(SDIST_TAR_FILE): ui-headless ui-next/headless |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make ui-next/headless a target of ui-headless so that if I run make ui-headless
from the root folder it will hit both targets?
I'd like to understand why this isn't happening in the awx-operator CI check... which builds AWX in headless mode and seems to be passing on other PRs. |
@echo "=== Creating empty awx/ui/build ===" | ||
@rm -rf awx/ui/build/static | ||
@mkdir -p awx/ui/build/static | ||
@touch awx/ui/build/static/HEADLESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is awx/ui/build/static/HEADLESS
supposed to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at this code, this command isn't supposed to get run when doing a headless build:
awx/tools/ansible/roles/dockerfile/templates/Dockerfile.j2
Lines 86 to 88 in bf98f62
{% if not headless|bool %} | |
RUN AWX_SETTINGS_FILE=/dev/null SKIP_SECRET_KEY_CHECK=yes SKIP_PG_VERSION_CHECK=yes /var/lib/awx/venv/awx/bin/awx-manage collectstatic --noinput --clear | |
{% endif %} |
Not sure how you got into this state, but I don't think more cruft in the Makefile is the answer here.
ok headless build is broken for |
fixed in #13658 bc its literally 1 line |
SUMMARY
headless build of awx end in following error
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
test:
🟢 IS able to access
/api/v2/
🟡
/
will showServer Error
(we can improve this by placing a dummy index.htlm in the static dir but out of scope of this PR)