Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve menu code #816

Merged
merged 4 commits into from
Jan 21, 2025

DRY-up

5b27f4e
Select commit
Loading
Failed to load commit list.
Merged

improve menu code #816

DRY-up
5b27f4e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 1s

28% (+1%) compared to b50bb63

View this Pull Request on Codecov

28% (+1%) compared to b50bb63

Details

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.

Project coverage is 28%. Comparing base (b50bb63) to head (5b27f4e).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/views/info_dialog.rs 0% 31 Missing ⚠️
src/views/dialog_styles.rs 0% 15 Missing ⚠️
src/views/info_row.rs 0% 15 Missing ⚠️
src/views/devices_menu.rs 0% 7 Missing ⚠️
src/views/connect_dialog.rs 0% 5 Missing ⚠️
src/views/layout_menu.rs 0% 5 Missing ⚠️
src/views/config_menu.rs 0% 4 Missing ⚠️
src/views/connection_menu.rs 0% 4 Missing ⚠️
src/views/ssid_dialog.rs 0% 2 Missing ⚠️
src/views/about.rs 0% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff           @@
##           master   #816    +/-   ##
======================================
+ Coverage      27%    28%    +1%     
======================================
  Files          46     47     +1     
  Lines        6060   5922   -138     
======================================
  Hits         1631   1631            
+ Misses       4429   4291   -138

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov