Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve menu code #816

Merged
merged 4 commits into from
Jan 21, 2025
Merged

improve menu code #816

merged 4 commits into from
Jan 21, 2025

Conversation

andrewdavidmackenzie
Copy link
Owner

DRY

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.

Project coverage is 28%. Comparing base (b50bb63) to head (5b27f4e).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/views/info_dialog.rs 0% 31 Missing ⚠️
src/views/dialog_styles.rs 0% 15 Missing ⚠️
src/views/info_row.rs 0% 15 Missing ⚠️
src/views/devices_menu.rs 0% 7 Missing ⚠️
src/views/connect_dialog.rs 0% 5 Missing ⚠️
src/views/layout_menu.rs 0% 5 Missing ⚠️
src/views/config_menu.rs 0% 4 Missing ⚠️
src/views/connection_menu.rs 0% 4 Missing ⚠️
src/views/ssid_dialog.rs 0% 2 Missing ⚠️
src/views/about.rs 0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #816    +/-   ##
======================================
+ Coverage      27%    28%    +1%     
======================================
  Files          46     47     +1     
  Lines        6060   5922   -138     
======================================
  Hits         1631   1631            
+ Misses       4429   4291   -138     
Flag Coverage Δ
unittests 28% <0%> (+1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewdavidmackenzie andrewdavidmackenzie merged commit 575116b into master Jan 21, 2025
17 checks passed
@andrewdavidmackenzie andrewdavidmackenzie deleted the menus_improvements branch January 21, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant