This repository has been archived by the owner on May 15, 2024. It is now read-only.
Fix: update eslint-config-amex to v12 #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PixnBits
commented
Sep 18, 2023
| @@ -34,16 +34,19 @@ function parseVersion(raw) { | |||
| return raw; | |||
| } | |||
|
|
|||
| const match = /^v?(\d+)\.(\d+)\.(\d+)(?:-(.+))?$/.exec(raw.trim()); | |||
There was a problem hiding this comment.
split out the parsing due to unicorn/no-unsafe-regex calling out the (?:-(.+))? bit
JAdshead
reviewed
Sep 19, 2023
Comment on lines
+198
to
+199
| mapModuleStateToProperties, | ||
| mapDispatchToProperties, |
There was a problem hiding this comment.
this goes against convention..
JAdshead
reviewed
Sep 19, 2023
| @@ -39,7 +39,7 @@ | |||
| "enzyme": "^3.11.0", | |||
| "enzyme-to-json": "^3.2.2", | |||
| "eslint": "^6.8.0", | |||
| "eslint-config-amex": "^11.2.0", | |||
| "eslint-config-amex": "^12.2.0", | |||
There was a problem hiding this comment.
I am not a fan of props to properties, I believe that this lint rule is removed in later versions.
There was a problem hiding this comment.
Ah! Though that's what "props" is short for I can add an ignore directive before the update to v13 👍
13 tasks
|
need to restart due to the |
|
#157 opened instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update eslint-config-amex to ^12
Automatic and manual fixes applied.
Motivation and Context
Prevent more issues!
How Has This Been Tested?
locally
$ npm run lint -- --fixand$ npm testTypes of Changes
Checklist:
What is the Impact to Developers Using Holocron?
Gain the assurances of the rules introduced in eslint-config-amex@12