-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
@@ -34,16 +34,19 @@ function parseVersion(raw) { | |||
return raw; | |||
} | |||
|
|||
const match = /^v?(\d+)\.(\d+)\.(\d+)(?:-(.+))?$/.exec(raw.trim()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split out the parsing due to unicorn/no-unsafe-regex calling out the (?:-(.+))?
bit
mapModuleStateToProperties, | ||
mapDispatchToProperties, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this goes against convention..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!!
@@ -39,7 +39,7 @@ | |||
"enzyme": "^3.11.0", | |||
"enzyme-to-json": "^3.2.2", | |||
"eslint": "^6.8.0", | |||
"eslint-config-amex": "^11.2.0", | |||
"eslint-config-amex": "^12.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a fan of props
to properties
, I believe that this lint rule is removed in later versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Though that's what "props" is short for I can add an ignore directive before the update to v13 👍
need to restart due to the |
#157 opened instead |
Description
Update eslint-config-amex to ^12
Automatic and manual fixes applied.
Motivation and Context
Prevent more issues!
How Has This Been Tested?
locally
$ npm run lint -- --fix
and$ npm test
Types of Changes
Checklist:
What is the Impact to Developers Using Holocron?
Gain the assurances of the rules introduced in eslint-config-amex@12