This repository has been archived by the owner on May 15, 2024. It is now read-only.
feat(holocron-module-register-plugin): move to webpack 5 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-forger
force-pushed
the
v2.0.0-alpha-webpack-5
branch
from
a2773c2
to
162287d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
@PixnBits The holocron package should not need a major version bump, only the webpack plugin |
JAdshead
reviewed
Oct 5, 2023
packages/holocron-module-register-webpack-plugin/HolocronModuleRegisterPlugin.js
Outdated
Show resolved
Hide resolved
JAdshead
reviewed
Oct 5, 2023
code-forger
force-pushed
the
v2.0.0-alpha-webpack-5
branch
2 times, most recently
from
6455ee1
to
3d20f15
Compare
code-forger
changed the title
BREAKING CHANGE : This change is breaking as it directely interacts with webpacks source structure, which is changed in v5
code-forger
force-pushed
the
v2.0.0-alpha-webpack-5
branch
from
1e3e691
to
b54c944
Compare
Matthew-Mallimo
previously approved these changes
Oct 13, 2023
Co-authored-by: Matthew Mallimo <[email protected]>
Matthew-Mallimo
previously approved these changes
Oct 13, 2023
10xLaCroixDrinker
suggested changes
Oct 13, 2023
| @@ -130,6 +134,6 @@ describe('HolocronModuleRegisterPlugin', () => { | |||
|
|
|||
| await waitForWebpack(options); | |||
| const fileContents = fs.readFileSync(path.join(buildPath, outputFileName)).toString(); | |||
| expect(fileContents.endsWith(`Holocron.registerModule("${moduleName}", ${holocronModuleName});})();`)).toBe(true); | |||
| expect(fileContents).toContain('Holocron.registerModule("some-module", holocronModule-some-module);'); | |||
There was a problem hiding this comment.
The kebab-case holocron-some-module can't be right. Isn't that supposed to be a variable name?
There was a problem hiding this comment.
Yes, however this tests shows that the plugin takes the name specified. We are specifying a non-camel-case module variable name up on Line 122
I have not changed this, just made the 'snapshot' literal instead of templated, so we can visually see that the name passed is accepted and inserted.
There was a problem hiding this comment.
Addressed in ea09da2
JAdshead
previously approved these changes
Oct 16, 2023
code-forger
dismissed stale reviews from JAdshead and Matthew-Mallimo
via
ea09da2
10xLaCroixDrinker
approved these changes
Oct 24, 2023
JAdshead
approved these changes
Oct 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support webpack 5 in a new major version of the registration plugin
NOTE: this should be released as alpha until its consumed into one-app-bundler and rigorously tested.
How Has This Been Tested?
unit tests, used to build a module locally
Types of Changes
Checklist:
What is the Impact to Developers Using Holocron?
None, should be perfectly drop in