Upgrade Rails to 7.2.0 #1672
Closed
Upgrade Rails to 7.2.0 #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the application settings for Rails 7.2. I'm not confident on what stuff to accept and what to reject from the output of this command, but I roughly based it off the upgrades to our other apps
This was referenced Aug 23, 2024
This was referenced Aug 27, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, Dependabot hasn't opened a PR for this. This performs the upgrade manually. I'm not sure how we usually decide what to accept and reject from the output of
rails app:update, so we might want to discuss that. I've roughly based it off upgrades to other apps we own, but they aren't entirely consistent and the decisions aren't documentedWe want to keep this in sync with Bouncer's activerecord version: currently this is 7.1.3.4 on production, but 7.2.0 on main (the deployment is broken). See:
NoMethodErrorbouncer#551This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.