Upgrade rails 7.2.1 #1679
Closed
Upgrade rails 7.2.1 #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [rails](https://github.com/rails/rails) from 7.1.3.4 to 7.2.1. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v7.1.3.4...v7.2.1) --- updated-dependencies: - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
We were getting the following error in `spec/support/database_cleaner.rb` ``` NoMethodError: undefined method `schema_migration' for an instance of ActiveRecord::ConnectionAdapters::PostgreSQLAdapter ``` Upgrading `database_cleaner-active_record` fixes this issue. Given that we appear to depend on this being up-to-date to successfully run the test suite, I've added this as a test dependency (we have it as one in some of our other repos)
This updates the application settings for Rails 7.2. I'm not confident on what stuff to accept and what to reject from the output of this command, but I roughly based it off the upgrades to our other apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1672, closes #1678
We want to keep Bouncer and Transition in sync (as detailed in both repos' READMEs), so we should merge the Bouncer equivalent alongside this one: alphagov/bouncer#556
I pushed some fixes to #1678 but GitHub's CI isn't happy that the Gemfile changed, so I'm opening a new PR to replace the old one(s)
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.