Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tablecloth library as it's no longer needed. #373

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Remove tablecloth library as it's no longer needed. #373

merged 5 commits into from
Jul 27, 2023

Commits on Jul 26, 2023

  1. Remove tablecloth library as it's no longer needed. 

    Now that we're finally containerised, we no longer need this library.

Which is lucky for us, because https://github.com/alext/tablecloth/ was
archived in February and the last commit was 4 years ago.
    @sengi
    sengi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    acfdcc7 View commit details
    Browse the repository at this point in the history

  2. go mod tidy && go mod vendor

    @sengi
    sengi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8007727 View commit details
    Browse the repository at this point in the history

  3. Specify timeouts on upstream connections. 

    This fixes a potential DoS vulnerability; see
https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/#httplistenandserveisdoingitwrong

While we're at it, parse the environment variables in main.go and pass
time.Duration around internally.
    @sengi
    sengi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    311ea25 View commit details
    Browse the repository at this point in the history

  4. Bind test API server to localhost. 

    Avoids some of the modal popups from the macOS firewall. Annoyingly
there's still one more coming from somewhere, maybe a test library
that's still binding to the zero address? Oh well.
    @sengi
    sengi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b6c2edb View commit details
    Browse the repository at this point in the history

  5. Update the triemux example to follow good practice. 

    http.ListenAndServe should never be used in production code, so let's
avoid using it in our examples.

Also clean up some old links and fix a tiny spelling/l10n issue :)
    @sengi
    sengi committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    777af7b View commit details
    Browse the repository at this point in the history