Remove tablecloth library as it's no longer needed. #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we're finally containerised, we no longer need this library. Which is lucky for us, because https://github.com/alext/tablecloth/ was archived in February and the last commit was 4 years ago.
|
cc @chao-xian |
|
Ooh nice, the gosec linter doesn't like us using http.ListenAndServe. Could just make it a TODO but since it's come up now and it should be an easy fix, I'll try to get it in this PR. (It's not a new problem; it's just that Tablecloth was obscuring the problem from the linter before.) edit: done! |
This fixes a potential DoS vulnerability; see https://blog.cloudflare.com/the-complete-guide-to-golang-net-http-timeouts/#httplistenandserveisdoingitwrong While we're at it, parse the environment variables in main.go and pass time.Duration around internally.
Avoids some of the modal popups from the macOS firewall. Annoyingly there's still one more coming from somewhere, maybe a test library that's still binding to the zero address? Oh well.
http.ListenAndServe should never be used in production code, so let's avoid using it in our examples. Also clean up some old links and fix a tiny spelling/l10n issue :)
sengi
force-pushed
the
sengi/rm-tablecloth
branch
from
cdb3f6b
to
777af7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're finally containerised, we no longer need this library.
Which is lucky for us, because https://github.com/alext/tablecloth/ was archived in February and the last commit was 4 years ago.
Recommend reviewing commit-by-commit since a chunk of this is just generated updates from
go mod.