Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Refactoring #18

Closed
wants to merge 20 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ concurrency:
cancel-in-progress: true

jobs:
lint:
name: lint
test:
name: test
runs-on: ubuntu-latest

steps:
Expand All @@ -30,5 +30,5 @@ jobs:

- name: Install dependencies
run: npm ci
- name: Run eslint
run: npm run lint
- name: Run linting and testing
run: npm run test
1 change: 1 addition & 0 deletions .github/workflows/update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ jobs:
# gdi was built as a documentation tool. This is especially true of the
# github action which doesn't give us the option to output this data as
# something like json which we can programmatically interogate.
# TODO: Run a similar script for our known manual ports as well
- name: Pipe our deps to a json file
run: npm -v
# run: github-dependents-info --repo alphagov/govuk-frontend --sort stars --json > ./data/raw-deps.json
Expand Down
5 changes: 5 additions & 0 deletions NOTES.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Current status

The new approach is working up to a point. There was a snafu with not awaiting async functions, and then there was a function I wasn't returning from. Then the rate limit hit!

Next step is to run the script again and keep bugfixing.
Loading
Loading