-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPIKE] Refactoring #18
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoscargin
force-pushed
the
bk-refactoring
branch
from
December 19, 2024 20:05
5396639
to
7f62501
Compare
domoscargin
force-pushed
the
bk-refactoring
branch
3 times, most recently
from
December 19, 2024 21:29
2400a54
to
236121d
Compare
domoscargin
force-pushed
the
bk-refactoring
branch
from
December 19, 2024 21:39
236121d
to
9849d43
Compare
domoscargin
force-pushed
the
bk-refactoring
branch
9 times, most recently
from
December 20, 2024 00:11
0486854
to
7c0a6bb
Compare
Things I want to do:
|
domoscargin
force-pushed
the
bk-refactoring
branch
9 times, most recently
from
December 27, 2024 20:30
b2814b5
to
5a77de6
Compare
domoscargin
force-pushed
the
bk-refactoring
branch
3 times, most recently
from
December 27, 2024 20:59
1712583
to
bc8c164
Compare
domoscargin
force-pushed
the
bk-refactoring
branch
6 times, most recently
from
December 31, 2024 22:27
f9b7a22
to
d23a809
Compare
The idea is that if we find one of these packages as a direct dependency, we can infer govuk-frontend's version. This would rely on a function which checks which package manager we're dealing with in the first instance, and therefore which files to check for dependencies. We could include manual ports here, and potentially run separate dependents data for them to get an idea of who's using the ports that don't use our package underlying and how much of a market there is.
domoscargin
force-pushed
the
bk-refactoring
branch
from
December 31, 2024 22:34
b00c342
to
ed53243
Compare
This has a separate rate limit, and getting this information basically doesn't impact it at all. Should save a few thousand REST API calls.
domoscargin
force-pushed
the
bk-refactoring
branch
from
January 1, 2025 21:00
a4bfd83
to
be7225d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hasty, untested refactoring:
I'm pushing and testing this now and I'm pretty sure it'll fail because there's quite a lot of changes. Let's see how it goes!
fixes #12