Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump activerecord from 7.1.3.4 to 7.2.0" #552

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

yndajas
Copy link
Member

@yndajas yndajas commented Aug 21, 2024

This reverts commit e589261.

According to comments in both the Bouncer and Transition Gemfiles, a few gems should be kept in sync between the two apps. ActiveRecord/Rails is one of them. Transition remains on 7.1.3.4 and Dependabot hasn't raised an upgrade PR as of yet

We've tried upgrading Transition, but there's an error that we don't know how to fix immediately, so a rollback is a quicker short-term fix


⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This reverts commit e589261.

According to comments in both the Bouncer and Transition Gemfiles, a few
gems should be kept in sync between the two apps. ActiveRecord/Rails is
one of them. Transition remains on 7.1.3.4 and Dependabot hasn't raised
an upgrade PR as of yet
Copy link
Contributor

@Gweaton Gweaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this one on integration (I'm assuming you did from #551 but wasn't sure)? I can't imagine there are any migrations/backwards compatibility issues but just to be extra safe

@yndajas
Copy link
Member Author

yndajas commented Aug 21, 2024

Have you tested this one on integration (I'm assuming you did from #551 but wasn't sure)? I can't imagine there are any migrations/backwards compatibility issues but just to be extra safe

Nope - only #551. I'll test it tomorrow

@yndajas
Copy link
Member Author

yndajas commented Aug 22, 2024

Have you tested this one on integration (I'm assuming you did from #551 but wasn't sure)? I can't imagine there are any migrations/backwards compatibility issues but just to be extra safe

Looks healthy from a manual deploy so I'll merge the PR chain

@yndajas yndajas merged commit c03946c into fix-deprecation Aug 22, 2024
7 checks passed
@yndajas yndajas deleted the revert-activerecord-upgrade branch August 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants