Merge pull request #534 from alphagov/dependabot/bundler/rubocop-govu…

…k-5.0.1

Bump rubocop-govuk from 4.18.0 to 5.0.1

Gemfile.lock

@@ -314,8 +314,8 @@ GEM
       opentelemetry-api (~> 1.0)
     optic14n (2.1.0)
       addressable (~> 2.7)
-    parallel (1.24.0)
-    parser (3.3.2.0)
+    parallel (1.25.1)
+    parser (3.3.3.0)
       ast (~> 2.4.1)
       racc
     pg (1.5.6)
@@ -371,8 +371,8 @@ GEM
       io-console (~> 0.5)
     request_store (1.7.0)
       rack (>= 1.4)
-    rexml (3.2.8)
-      strscan (>= 3.0.9)
+    rexml (3.3.1)
+      strscan
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -399,30 +399,24 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.31.3)
       parser (>= 3.3.1.0)
-    rubocop-capybara (2.20.0)
+    rubocop-capybara (2.21.0)
       rubocop (~> 1.41)
-    rubocop-factory_bot (2.25.1)
-      rubocop (~> 1.41)
-    rubocop-govuk (4.18.0)
+    rubocop-govuk (5.0.1)
       rubocop (= 1.64.1)
       rubocop-ast (= 1.31.3)
+      rubocop-capybara (= 2.21.0)
       rubocop-rails (= 2.25.0)
       rubocop-rake (= 0.6.0)
-      rubocop-rspec (= 2.30.0)
+      rubocop-rspec (= 3.0.1)
     rubocop-rails (2.25.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.30.0)
-      rubocop (~> 1.40)
-      rubocop-capybara (~> 2.17)
-      rubocop-factory_bot (~> 2.22)
-      rubocop-rspec_rails (~> 2.28)
-    rubocop-rspec_rails (2.28.3)
-      rubocop (~> 1.40)
+    rubocop-rspec (3.0.1)
+      rubocop (~> 1.61)
     ruby-progressbar (1.13.0)
     sentry-rails (5.17.3)
       railties (>= 5.0)

spec/features/http_request_handling_spec.rb

@@ -44,7 +44,7 @@ def app
     describe "#location" do
       subject { super().location }
 
-      it { is_expected.to eq(nil) }
+      it { is_expected.to be_nil }
     end
 
     specify { expect(last_response.headers).not_to include("Cache-Control") }
@@ -252,7 +252,7 @@ def app
     describe "#location" do
       subject { super().location }
 
-      it { is_expected.to eq(nil) }
+      it { is_expected.to be_nil }
     end
   end
 
@@ -830,7 +830,7 @@ def app
     describe "#location" do
       subject { super().location }
 
-      it { is_expected.to eq(nil) }
+      it { is_expected.to be_nil }
     end
   end
 
@@ -1147,7 +1147,7 @@ def app
         describe "#location" do
           subject { super().location }
 
-          it { is_expected.to eq(nil) }
+          it { is_expected.to be_nil }
         end
       end
     end
@@ -1285,7 +1285,7 @@ def app
         describe "#location" do
           subject { super().location }
 
-          it { is_expected.to eq(nil) }
+          it { is_expected.to be_nil }
         end
       end
     end

spec/performance/benchmark_spec.rb

@@ -1,7 +1,7 @@
 require_relative "../../boot"
 require_relative "../../lib/benchmark/all"
 
-describe "Benchmarking", performance: true do
+describe "Benchmarking", :performance do
   include Rack::Test::Methods
 
   def app
@@ -10,7 +10,7 @@ def app
 
   let(:number_of_runs) { ENV["NUMBER_OF_RUNS"] || 1000 }
 
-  it "generates timings for no host, 301, 410, 404" do
+  it "generates timings for no host, 301, 410, 404" do # rubocop:disable RSpec/NoExpectationExample
     Benchmark::All.new(number_of_runs).run!
   end
 end

spec/units/bouncer/canonicalized_request_spec.rb

@@ -8,7 +8,7 @@
 
     it "returns true if valid URI passed" do
       canonicalized_request = described_class.new(env)
-      allow(canonicalized_request).to receive(:bluri).and_return(instance_double("Rack::Request"))
+      allow(canonicalized_request).to receive(:bluri).and_return(instance_double(Rack::Request))
       expect(canonicalized_request.valid?).to be(true)
     end