Skip to content

Commit

Permalink
Fix Rubocop violations after bumping rubocop-govuk
Browse files Browse the repository at this point in the history
from 4.18.0 to 5.0.1
  • Loading branch information
Gweaton committed Jun 26, 2024
1 parent f802754 commit 53a9d86
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions spec/features/http_request_handling_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def app
describe "#location" do
subject { super().location }

it { is_expected.to eq(nil) }
it { is_expected.to be_nil }
end

specify { expect(last_response.headers).not_to include("Cache-Control") }
Expand Down Expand Up @@ -252,7 +252,7 @@ def app
describe "#location" do
subject { super().location }

it { is_expected.to eq(nil) }
it { is_expected.to be_nil }
end
end

Expand Down Expand Up @@ -830,7 +830,7 @@ def app
describe "#location" do
subject { super().location }

it { is_expected.to eq(nil) }
it { is_expected.to be_nil }
end
end

Expand Down Expand Up @@ -1147,7 +1147,7 @@ def app
describe "#location" do
subject { super().location }

it { is_expected.to eq(nil) }
it { is_expected.to be_nil }
end
end
end
Expand Down Expand Up @@ -1285,7 +1285,7 @@ def app
describe "#location" do
subject { super().location }

it { is_expected.to eq(nil) }
it { is_expected.to be_nil }
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/performance/benchmark_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require_relative "../../boot"
require_relative "../../lib/benchmark/all"

describe "Benchmarking", performance: true do
describe "Benchmarking", :performance do
include Rack::Test::Methods

def app
Expand All @@ -10,7 +10,7 @@ def app

let(:number_of_runs) { ENV["NUMBER_OF_RUNS"] || 1000 }

it "generates timings for no host, 301, 410, 404" do
it "generates timings for no host, 301, 410, 404" do # rubocop:disable RSpec/NoExpectationExample
Benchmark::All.new(number_of_runs).run!
end
end
2 changes: 1 addition & 1 deletion spec/units/bouncer/canonicalized_request_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

it "returns true if valid URI passed" do
canonicalized_request = described_class.new(env)
allow(canonicalized_request).to receive(:bluri).and_return(instance_double("Rack::Request"))
allow(canonicalized_request).to receive(:bluri).and_return(instance_double(Rack::Request))
expect(canonicalized_request.valid?).to be(true)
end

Expand Down

0 comments on commit 53a9d86

Please sign in to comment.