Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO-1530: Upgrade constructs #1073

Merged
merged 10 commits into from
Sep 29, 2023
Merged

DO-1530: Upgrade constructs #1073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dabddc2
DO-1534: upgrade rabbitmq construct
gowrizrh Sep 27, 2023
ff3c5a3
DO-1530: move esbuild to own package
gowrizrh Sep 27, 2023
80cb9d5
DO-1535: upgrade geoip redirect construct
gowrizrh Sep 27, 2023
023308b
DO-1533: upgrade shared-vpc construct
gowrizrh Sep 27, 2023
08b2566
DO-1532: upgrade waf construct to cdk 2
gowrizrh Sep 27, 2023
bdb63fc
DO-1541: upgrade prerender proxy construct
gowrizrh Sep 27, 2023
1607818
DO-1542:upgrade lambda handlers package
gowrizrh Sep 27, 2023
899cac2
DO-1530: move @types/aws-lambda to dev dependencies
gowrizrh Sep 27, 2023
ae7f0d6
DO-1530: update identifiers to be consistent
gowrizrh Sep 27, 2023
fc7f46a
DO-1530: run formatter and readd build command
gowrizrh Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.18.1
20.7.0
293 changes: 293 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
},
"homepage": "https://github.com/aligent/aws-cdk-constructs#readme",
"scripts": {
"build": "",
"prepublish": "",
"build": "tsc",
"prepublish": "tsc",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tsc on prepublish? 🤔 Just thinking in the pipeline we'd probably build and then publish so this would run tsc twice. If we're just gonna run publish I think changing from tsc to npm run build makes more sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this currently exists in the main branch. i only removed the commands for convenience and then re-added them back 🤔

"lint": "eslint --ignore-path .eslintignore --ext .ts .",
"lint:check": "npm run lint",
"lint:fix": "npm run lint --fix",
Expand Down
Loading
Loading