DO-1530: Upgrade constructs #1073
Conversation
gowrizrh
requested review from
TheOrangePuff,
AdamJHall,
krishanthisera and
crispy101
* upgrade basic-auth construct * upgrade cloudfront-security-headers construct
gowrizrh
changed the title
| "build": "", | ||
| "prepublish": "", | ||
| "build": "tsc", | ||
| "prepublish": "tsc", |
There was a problem hiding this comment.
Why tsc on prepublish? 🤔 Just thinking in the pipeline we'd probably build and then publish so this would run tsc twice. If we're just gonna run publish I think changing from tsc to npm run build makes more sense
There was a problem hiding this comment.
this currently exists in the main branch. i only removed the commands for convenience and then re-added them back 🤔
| ) { | ||
| super(scope, id); | ||
|
|
||
| const defineOptions: any = {}; |
There was a problem hiding this comment.
Is there a type for this rather than any?
There was a problem hiding this comment.
i think we could add __CONTENT_SECURITY_POLICY__ 🤔
There was a problem hiding this comment.
Do we need to include this if it's all commented out? 😅
There was a problem hiding this comment.
probably not, i'm not sure if this was even right, but i didn't spend anytime migrating tests 😛
|
thanks @TheOrangePuff, i'll make the suggested changes in a separate PR |
Description of the proposed changes
basic-authconstruct to CDK v2cloudfront-security-headersto CDK v2geoip-redirectto CDK v2lambda-at-edge-handlersprerender-proxyto CDK v2rabbitmqto CDK v2shared-vpcto CDK v2wafto CDK v2